update couple code and typo

AvocadoAmber/couple/index.php

@@ -1,54 +1,40 @@
 <?php
 include_once './_common.php';
 
-
-$sql_common = " from {$g5['couple_table']} ";
-$sql_search = "  ";
-$sql_order = " order by co_order asc ";
-$sql_limit = "";
-$sql = " select * {$sql_common} {$sql_search} {$sql_order} ";
+$sql = "SELECT * FROM {$g5['couple_table']} ORDER BY co_order ASC";
 $result = sql_query($sql);
 
 $list = [];
-for ($i = 0; $co = sql_fetch_array($result); $i++) {
-  $list[$i] = $co;
+$current_time = time();
 
+while ($co = sql_fetch_array($result)) {
   $ch_left = Character::getDetail($co['co_left'], ["ch_name", "ch_thumb", "mb_id"]);
   $ch_right = Character::getDetail($co['co_right'], ["ch_name", "ch_thumb", "mb_id"]);
 
-  $ch_left['ch_name'] = explode(' ', $ch_left['ch_name']);
-  $ch_left['ch_name'] = $ch_left['ch_name'][0];
+  $day = ceil(($current_time - date("U", strtotime($co['co_date']))) / 86400);
 
-  $ch_right['ch_name'] = explode(' ', $ch_right['ch_name']);
-  $ch_right['ch_name'] = $ch_right['ch_name'][0];
-
-  $h = date('H'); //현재시를 구함 
-  $m = date('i'); //현재 분을 구함 
-  $s = date('s'); //현재 초를 구함 
-  $date = date("U", strtotime($co['co_date'])); //생일의 유닉스타임스탬프를 구함 
-  $today = time(); //현재의 유닉스타임스탬프를 구함 
-  $day = ($today - $date) / 60 / 60 / 24; //몇일이지났는가를 계산
-  $day = ceil($day);
-
-  $list[$i]['left']['idx'] = $co['co_left'];
-  $list[$i]['left']['name'] = $ch_left['ch_name'];
-  $list[$i]['left']['thumb'] = $ch_left['ch_thumb'];
-
-  $list[$i]['right']['idx'] = $co['co_right'];
-  $list[$i]['right']['name'] = $ch_right['ch_name'];
-  $list[$i]['right']['thumb'] = $ch_right['ch_thumb'];
-
-  $list[$i]['dday'] = $day;
+  $list[] = [
+    'left' => [
+      'idx' => $co['co_left'],
+      'name' => explode(' ', $ch_left['ch_name'])[0],
+      'thumb' => $ch_left['ch_thumb'],
+    ],
+    'right' => [
+      'idx' => $co['co_right'],
+      'name' => explode(' ', $ch_right['ch_name'])[0],
+      'thumb' => $ch_right['ch_thumb'],
+    ],
+    'dday' => $day,
+  ];
 }
 
-
 $g5['title'] = "커플";
 include_once './_head.php';
 
-if (defined('G5_THEME_PATH') && is_file(G5_THEME_PATH . "/couple/list.skin.php")) {
-  include G5_THEME_PATH . "/couple/list.skin.php";
-} else {
-  include G5_PATH . "/couple/skin/list.skin.php";
-}
+$skin = defined('G5_THEME_PATH') && is_file(G5_THEME_PATH . "/couple/list.skin.php")
+  ? G5_THEME_PATH . "/couple/list.skin.php"
+  : G5_PATH . "/couple/skin/list.skin.php";
+
+include $skin;
 
 include_once G5_PATH . '/tail.php';

AvocadoAmber/couple/skin/list.skin.php

@@ -1,11 +1,9 @@
 <?php
 if (!defined('_GNUBOARD_'))
-  exit; 
+  exit;
 add_stylesheet('<link rel="stylesheet" href="' . G5_CSS_URL . '/style.couple.css">', 0);
 ?>
-
 <div id="couple_page">
-
   <div id="couple_list">
     <ul>
       <?php for ($i = 0; $i < count($list); $i++) { ?>
@@ -14,13 +12,11 @@ add_stylesheet('<link rel="stylesheet" href="' . G5_CSS_URL . '/style.couple.css
             <a href="<?= G5_URL ?>/member/viewer.php?ch_id=<?= $list[$i]['left']['idx'] ?>" class="left" target="_blank">
               <img src="<?= $list[$i]['left']['thumb'] ?>" />
             </a>
-
             <a href="<?= G5_URL ?>/member/viewer.php?ch_id=<?= $list[$i]['right']['idx'] ?>" class="right"
               target="_blank">
               <img src="<?= $list[$i]['right']['thumb'] ?>" />
             </a>
           </div>
-
           <p>
             <?= $list[$i]['left']['name'] ?> ♥ <?= $list[$i]['right']['name'] ?> 커플<br />
             <?= $list[$i]['dday'] ?>일 째입니다.
@@ -28,6 +24,5 @@ add_stylesheet('<link rel="stylesheet" href="' . G5_CSS_URL . '/style.couple.css
         </li>
       <?php } ?>
     </ul>
-
   </div>
 </div>

AvocadoAmber/tail.sub.php

@@ -12,14 +12,14 @@ if (!defined('G5_IS_ADMIN') && defined('G5_THEME_PATH') && file_exists(G5_THEME_
   include_once G5_THEME_PATH . '/tail.sub.php';
   return;
 }
+
 unset($mb);
 unset($row);
 unset($row2);
 
 EventHandler::triggerEvent("gnuboard.tail_sub");
-?>
-</body>
 
-</html>
-<?php
+echo "</body>" . PHP_EOL;
+echo "</html>" . PHP_EOL;
+
 echo html_end();

README.md

@@ -13,7 +13,7 @@ AvocadoEdition Light 의 구조를 바탕으로 GNUBoard 기능과 함께 재수
 개선하고 보강한 기능으로 `EventHandler::addEventHandler(...)` 함수를 사용해    
 필요한 곳에서 호출하여 코드를 변경시킬 수 있습니다.
 
-- 아보카도 퍼스널과 대부분 호환됩니다. (문제가 있다면 알려주세요!)
+- 아보카도 퍼스널 기반 기능들과 호환됩니다. (문제가 있다면 알려주세요!)
 
 -----------------------------