From 90dd3e7113e7603c41deefa2d3d09f935f6fcab7 Mon Sep 17 00:00:00 2001
From: Arcturus <github@drk.st>
Date: Wed, 23 Oct 2024 00:08:19 +0900
Subject: [PATCH] update

---
 list.skin.php        | 104 ++++++++++++++++++-----------------
 readme.md            |   1 +
 set_order.php        | 125 ++++++++++++++++++++++---------------------
 set_order_update.php |  24 +++++----
 4 files changed, 131 insertions(+), 123 deletions(-)

diff --git a/list.skin.php b/list.skin.php
index 26b09a8..2f869ba 100644
--- a/list.skin.php
+++ b/list.skin.php
@@ -19,11 +19,12 @@ $lists = array();
   if ($is_category) {
     $cate = explode('|', $board['bo_category_list']);
   }
+
   for ($h = 0; $h <= count($cate); $h++) {
     if (count($cate) > 0 && $h == count($cate))
       continue;
-    $list_item = sql_query("select * from {$write_table} where wr_reply='' and wr_is_comment=0 order by wr_10*1, wr_id");
 
+    $list_item = sql_query("SELECT * FROM {$write_table} WHERE wr_reply='' AND wr_is_comment=0 ORDER BY wr_10*1, wr_id");
     for ($k = 0; $row = sql_fetch_array($list_item); $k++) {
       $lists[$k] = get_list($row, $board, $board_skin_url);
     }
@@ -33,57 +34,61 @@ $lists = array();
         <h2><?= $cate[$h] ?></h2>
       <?php } ?>
       <ul class="list_box">
+      <?php if (count($lists) > 0) { ?>
         <?php
-        if (count($lists) > 0) {
-          for ($i = 0; $i < count($lists); $i++) {
-            // 수정, 삭제 링크
-            $update_href = $delete_href = "";
-            // 로그인중이고 자신의 글이라면 또는 관리자라면 패스워드를 묻지 않고 바로 수정, 삭제 가능
-            if (($member['mb_id'] && ($member['mb_id'] == $lists[$i]['mb_id'])) || $is_admin) {
-              $update_href = "./write.php?w=u&bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&page=$page" . $qstr;
-              $delete_href = "javascript:del('./delete.php?bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&page=$page" . urldecode($qstr) . "');";
-              if ($is_admin) {
-                $delete_href = "javascript:del('./delete.php?bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&token=$token&page=$page" . urldecode($qstr) . "');";
-              }
-            } else if (!$lists[$i]['mb_id']) { // 회원이 쓴 글이 아니라면
-              $update_href = "./password.php?w=u&bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&page=$page" . $qstr;
-              $delete_href = "./password.php?w=d&bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&page=$page" . $qstr;
-            }
+        for ($i = 0; $i < count($lists); $i++) {
+          if ($is_category) {
+            if (($lists[$i]['ca_name'] != $cate[$h]) || ($sca && $lists[$i]['ca_name'] != $sca))
+              continue;
+          }
 
-            if ($is_category) {
-              if (($lists[$i]['ca_name'] != $cate[$h]) || ($sca && $lists[$i]['ca_name'] != $sca))
-                continue;
+          // 수정, 삭제 링크
+          $update_href = "";
+          $delete_href = "";
+
+          // 로그인중이고 자신의 글이라면 또는 관리자라면 패스워드를 묻지 않고 바로 수정, 삭제 가능
+          if (($member['mb_id'] && ($member['mb_id'] == $lists[$i]['mb_id'])) || $is_admin) {
+            $update_href = "./write.php?w=u&bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&page=$page" . $qstr;
+            $delete_href = "javascript:del('./delete.php?bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&page=$page" . urldecode($qstr) . "');";
+            if ($is_admin) {
+              $delete_href = "javascript:del('./delete.php?bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&token=$token&page=$page" . urldecode($qstr) . "');";
             }
-            $_link = $lists[$i]['wr_link2'] ? $lists[$i]['wr_link2'] : "javascript:void(0);";
-            $_secret = strstr($lists[$i]['wr_option'], 'secret') ? " secret" : "";
-            $_extraattr = "style=\"cursor:default;\" onclick=\"return false;\" ";
-            ?>
-            <li class="bo-list">
-              <a href="<?= $_link ?>" target="_blank" class="link-banner<?= $_secret ?>" <?= !$lists[$i]['wr_link2'] ? $_extraattr : "" ?>>
-                <?php if ($lists[$i]['wr_link1']) { ?>
-                  <img src="<?= $lists[$i]['wr_link1'] ?>" alt="<?= $lists[$i]['wr_1'] ?>">
-                <?php } else { ?>
-                  <strong><?= $lists[$i]['wr_1'] ?></strong>
-                <?php } ?>
-              </a>
-              <p class="link-desc">
-                <?php if ($lists[$i]['wr_1'] && $lists[$i]['wr_link1']) {
-                  ?>
-                  <a href="<?= $link ?>" target="_blank" <?= !$lists[$i]['wr_link2'] ? $_extraattr : "" ?>class="name">
-                    <strong>
-                      <?= $lists[$i]['wr_1'] ?>
-                    </strong>
-                  </a>
-                <?php } ?>
-                <?php if ($update_href || $delete_href) { ?>
-                  <span class="options">
-                    <?php if ($update_href) { ?><a href="<?= $update_href ?>">*</a><?php } ?>
-                    <?php if ($delete_href) { ?><a href="<?= $delete_href ?>">-</a><?php } ?>
-                  </span>
-                <?php } ?>
-              </p>
-            </li><?php }
-        } ?>
+          } else if (!$lists[$i]['mb_id']) { // 회원이 쓴 글이 아니라면
+            $update_href = "./password.php?w=u&bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&page=$page" . $qstr;
+            $delete_href = "./password.php?w=d&bo_table=$bo_table&wr_id={$lists[$i]['wr_id']}&page=$page" . $qstr;
+          }
+
+          $_link = $lists[$i]['wr_link2'] ? $lists[$i]['wr_link2'] : "javascript:void(0);";
+          $_secret = strstr($lists[$i]['wr_option'], 'secret') ? " secret" : "";
+          $_extraattr = "style=\"cursor:default;\" onclick=\"return false;\" ";
+          ?>
+          <li class="bo-list">
+            <a href="<?= $_link ?>" target="_blank" class="link-banner<?= $_secret ?>" <?= !$lists[$i]['wr_link2'] ? $_extraattr : "" ?>>
+              <?php if ($lists[$i]['wr_link1']) { ?>
+                <img src="<?= $lists[$i]['wr_link1'] ?>" alt="<?= $lists[$i]['wr_1'] ?>">
+              <?php } else { ?>
+                <strong><?= $lists[$i]['wr_1'] ?></strong>
+              <?php } ?>
+            </a>
+            <p class="link-desc">
+              <?php if ($lists[$i]['wr_1'] && $lists[$i]['wr_link1']) {
+                ?>
+                <a href="<?= $link ?>" target="_blank" <?= !$lists[$i]['wr_link2'] ? $_extraattr : "" ?>class="name">
+                  <strong>
+                    <?= $lists[$i]['wr_1'] ?>
+                  </strong>
+                </a>
+              <?php } ?>
+              <?php if ($update_href || $delete_href) { ?>
+                <span class="options">
+                  <?php if ($update_href) { ?><a href="<?= $update_href ?>">*</a><?php } ?>
+                  <?php if ($delete_href) { ?><a href="<?= $delete_href ?>">-</a><?php } ?>
+                </span>
+              <?php } ?>
+            </p>
+          </li>
+        <?php } ?>
+      <?php } ?>
       </ul>
     </div>
   <?php } ?>
@@ -113,5 +118,4 @@ $lists = array();
     </div>
   <?php } ?>
 </div>
-
 <!-- } 게시판 목록 끝 -->
diff --git a/readme.md b/readme.md
index 84a86c4..404f616 100644
--- a/readme.md
+++ b/readme.md
@@ -7,6 +7,7 @@
 
 ### 주요 수정 사항
 - short open tag 제거
+- list.skin.php 수정
 
 모든 아보카도 버전에 호환됩니다.
 
diff --git a/set_order.php b/set_order.php
index b4d2ed0..1f1c98d 100644
--- a/set_order.php
+++ b/set_order.php
@@ -1,73 +1,74 @@
 <?php
 include_once "./_common.php";
 include_once G5_PATH . "/head.sub.php";
+
 add_stylesheet('<link rel="stylesheet" href="' . $board_skin_url . '/style.css">', 0);
-if ($board['bo_write_level'] <= $member['mb_level']) {
-  ?>
-  <form action="<?= $board_skin_url ?>/set_order_update.php" name="orders" method="post" autocomplete="off">
-    <input type="hidden" name="bo_table" value="<?= $bo_table ?>">
-    <input type="hidden" name="write_table" value="<?= $write_table ?>">
-    <div style="max-width:1000px;margin:10px auto;">
-      <table class="theme-form">
-        <colgroup>
+
+if ($board['bo_write_level'] <= $member['mb_level']) { ?>
+<form action="<?= $board_skin_url ?>/set_order_update.php" name="orders" method="post" autocomplete="off">
+  <input type="hidden" name="bo_table" value="<?= $bo_table ?>">
+  <input type="hidden" name="write_table" value="<?= $write_table ?>">
+  <div style="max-width:1000px;margin:10px auto;">
+    <table class="theme-form">
+      <colgroup>
+        <?php if ($board['bo_use_category'] && $board['bo_category_list']) { ?>
+          <col style="width:100px;">
+        <?php } ?>
+        <col style="width:150px;">
+        <col>
+        <col>
+        <col style="width:80px;">
+      </colgroup>
+      <tbody>
+        <tr>
           <?php if ($board['bo_use_category'] && $board['bo_category_list']) { ?>
-            <col style="width:100px;">
+            <th>카테고리</th>
           <?php } ?>
-          <col style="width:150px;">
-          <col>
-          <col>
-          <col style="width:80px;">
-        </colgroup>
-        <tbody>
+          <th>제목</th>
+          <th>배너</th>
+          <th>링크</th>
+          <th>순서</th>
+        </tr>
+        <?php
+        $order = sql_query("SELECT * FROM {$write_table} ORDER BY wr_10*1, wr_id");
+        for ($i = 0; $row = sql_fetch_array($order); $i++) { ?>
           <tr>
             <?php if ($board['bo_use_category'] && $board['bo_category_list']) { ?>
-              <th>카테고리</th>
-            <?php } ?>
-            <th>제목</th>
-            <th>배너</th>
-            <th>링크</th>
-            <th>순서</th>
+              <td>
+                <select name="category[<?= $row['wr_id'] ?>]">
+                  <option value="">카테고리</option>
+                  <?php
+                  $cate = explode('|', $board['bo_category_list']);
+                  for ($h = 0; $h < count($cate); $h++) { ?>
+                    <option value="<?= $cate[$h] ?>" <?= $row['ca_name'] == $cate[$h] ? "selected" : ""; ?>>
+                      <?= $cate[$h] ?>
+                    </option>
+                  <?php } ?>
+                </select>
+              <?php } ?>
+            </td>
+            <td>
+              <input type="text" name="subject[<?= $row['wr_id'] ?>]" value="<?= $row['wr_1'] ?>" style="width:100%;">
+            </td>
+            <td>
+              <input type="text" name="banner[<?= $row['wr_id'] ?>]" value="<?= $row['wr_link1'] ?>" style="width:100%;">
+            </td>
+            <td>
+              <input type="text" name="link[<?= $row['wr_id'] ?>]" value="<?= $row['wr_link2'] ?>" style="width:100%;">
+            </td>
+            <td>
+              <input type="text" name="order[<?= $row['wr_id'] ?>]" value="<?= $row['wr_10'] ?>" size="4">
+              <input type="hidden" name="idx[]" value="<?= $row['wr_id'] ?>">
+            </td>
           </tr>
-          <?php
-          $order = sql_query("select * from {$write_table} order by wr_10*1, wr_id");
-          for ($i = 0; $row = sql_fetch_array($order); $i++) { ?>
-            <tr>
-              <?php if ($board['bo_use_category'] && $board['bo_category_list']) { ?>
-                <td>
-                  <select name="category[<?= $row['wr_id'] ?>]">
-                    <option value="">카테고리</option>
-                    <?php
-                    $cate = explode('|', $board['bo_category_list']);
-                    for ($h = 0; $h < count($cate); $h++) { ?>
-                      <option value="<?= $cate[$h] ?>" <?= $row['ca_name'] == $cate[$h] ? "selected" : ""; ?>>
-                        <?= $cate[$h] ?>
-                      </option>
-                    <?php } ?>
-                  </select>
-                <?php } ?>
-              </td>
-              <td>
-                <input type="text" name="subject[<?= $row['wr_id'] ?>]" value="<?= $row['wr_1'] ?>" style="width:100%;">
-              </td>
-              <td>
-                <input type="text" name="banner[<?= $row['wr_id'] ?>]" value="<?= $row['wr_link1'] ?>" style="width:100%;">
-              </td>
-              <td>
-                <input type="text" name="link[<?= $row['wr_id'] ?>]" value="<?= $row['wr_link2'] ?>" style="width:100%;">
-              </td>
-              <td>
-                <input type="text" name="order[<?= $row['wr_id'] ?>]" value="<?= $row['wr_10'] ?>" size="4">
-                <input type="hidden" name="idx[]" value="<?= $row['wr_id'] ?>">
-              </td>
-            </tr>
-          <?php } ?>
-        </tbody>
-      </table>
-      <br>
-      <div style="float:right;">
-        <button type="submit" class="ui-btn point">확인</button>
-        <a href="<?= G5_BBS_URL ?>/board.php?bo_table=<?= $bo_table ?>" class="ui-btn">목록으로</a>
-      </div>
+        <?php } ?>
+      </tbody>
+    </table>
+    <br>
+    <div style="float:right;">
+      <button type="submit" class="ui-btn point">확인</button>
+      <a href="<?= G5_BBS_URL ?>/board.php?bo_table=<?= $bo_table ?>" class="ui-btn">목록으로</a>
     </div>
-  </form>
+  </div>
+</form>
 <?php } ?>
diff --git a/set_order_update.php b/set_order_update.php
index e6801b6..bff6d9d 100644
--- a/set_order_update.php
+++ b/set_order_update.php
@@ -1,17 +1,19 @@
 <?php
 include_once "./_common.php";
 
-for ($i = 0; $i < count($idx); $i++) {
-  $k = $idx[$i];
-  sql_query("update {$write_table}
-		set wr_10 = '{$order[$k]}',
-			wr_1 = '{$subject[$k]}',
-			wr_link1='{$banner[$k]}',
-			wr_link2='{$link[$k]}'
-		where wr_id='{$k}'
-	");
-  if ($board['bo_use_category'] && $board['bo_category_list'] && $category[$k] != '') {
-    sql_query("update {$write_table} set ca_name='{$category[$k]}' where wr_id='{$k}'");
+if (is_array($idx)) {
+  for ($i = 0; $i < count($idx); $i++) {
+    $k = $idx[$i];
+    sql_query("UPDATE {$write_table}
+      SET wr_10 = '{$order[$k]}',
+        wr_1 = '{$subject[$k]}',
+        wr_link1='{$banner[$k]}',
+        wr_link2='{$link[$k]}'
+      WHERE wr_id='{$k}'
+    ");
+    if ($board['bo_use_category'] && $board['bo_category_list'] && $category[$k] != '') {
+      sql_query("update {$write_table} set ca_name='{$category[$k]}' where wr_id='{$k}'");
+    }
   }
 }